New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashing when no tor ports are defined + Czech language #3

Open

radimkarnis wants to merge 2 commits into soyrubio:master from radimkarnis:master

radimkarnis commented Jul 22, 2021

puppeteer is run with an argument port_arg, which is expected to be a string. When no tor ports are defined, port_arg is declared without a value and therefore is undefined, which results in a crash. This is fixed by declaring it as an empty string in the first place.
Czech language is fixed. (was loading the Slovak language instead)

Closes #2


          Fix running puppeteer without defined tor ports

6e6738e

radimkarnis force-pushed the master branch from 62e687f to 5c50477 Compare

July 22, 2021 22:19


          Fix czech language

0f71db8

radimkarnis force-pushed the master branch from 5c50477 to 0f71db8 Compare

July 22, 2021 22:48

Alainfyf commented Mar 5, 2024

Hi radimkarnis,

I follow your correction and it works for some time. But after some months appear other problem I think not related with the first one.

The log that appears is: MMM-idos fetch error: TypeError: Cannot read properties of undefined (reading 'replace')

I try to solve the problem at the node but I couldn't find nothing...

Could you help me with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet